Skip to content

Use request context from SDK within pipeline #5985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Use request context from SDK within pipeline #5985

merged 1 commit into from
Mar 11, 2025

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Mar 10, 2025 •
edited
Loading

Use SDK request context from opsmill/infrahub-sdk-python#296.

Other changes:

  • In the apply_external_context function I've made a change to return early if the supplied context account is the same as the current session account. This is to avoid doing extra database lookups if we don't need them
  • Replaces the context when running generators within the pipeline

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Mar 10, 2025
@ogenstad ogenstad mentioned this pull request Mar 10, 2025
Merged
@ogenstad ogenstad force-pushed the pog-use-request-context-IFC-1340 branch from e79c0a5 to 5eb2168 Compare March 10, 2025 14:22
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 10, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5985 will not alter performance

Comparing pog-use-request-context-IFC-1340 (4009138) with release-1.2 (bdddfc1)

Summary

✅ 10 untouched benchmarks

@github-actions github-actions bot added the type/documentation Improvements or additions to documentation label Mar 10, 2025
@ogenstad ogenstad marked this pull request as ready for review March 10, 2025 15:59
@ogenstad ogenstad requested review from a team as code owners March 10, 2025 15:59
@ogenstad ogenstad force-pushed the pog-use-request-context-IFC-1340 branch from 5eb2168 to c9bf14e Compare March 11, 2025 07:30
@ogenstad ogenstad force-pushed the pog-use-request-context-IFC-1340 branch from c9bf14e to 4009138 Compare March 11, 2025 08:21
@ogenstad ogenstad merged commit 1c9a3ca into release-1.2 Mar 11, 2025
32 checks passed
@ogenstad ogenstad deleted the pog-use-request-context-IFC-1340 branch March 11, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgarros dgarros dgarros approved these changes

Assignees

No one assigned

Labels

group/backend Issue related to the backend (API Server, Git Agent) type/documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ogenstad @dgarros